Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SDFormat xml output of sdf_exporter #2156

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Sep 20, 2023

🦟 Bug fix

Fixes gazebosim/gazebo_test_cases#207

Summary

The warnings were caused by improper xml hierarchy.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Fixes the warnings reported in gazebosim/gazebo_test_cases#207

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from mjcarroll as a code owner September 20, 2023 16:48
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 20, 2023
@azeey azeey added the beta Targeting beta release of upcoming collection label Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Merging #2156 (509f20f) into gz-sim7 (9d79b62) will not change coverage.
The diff coverage is n/a.

❗ Current head 509f20f differs from pull request most recent head 87c21d5. Consider uploading reports for the commit 87c21d5 to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2156   +/-   ##
========================================
  Coverage    65.01%   65.01%           
========================================
  Files          356      356           
  Lines        28932    28932           
========================================
  Hits         18809    18809           
  Misses       10123    10123           

@azeey
Copy link
Contributor Author

azeey commented Sep 20, 2023

Looks like INTEGRATION_apply_link_wrench_system is flaky on Github Actions. /cc @Henrique-BO. I'll go ahead and merge since this only touches examples.

@azeey azeey merged commit 3eb2c7c into gazebosim:gz-sim7 Sep 20, 2023
4 of 5 checks passed
@azeey azeey deleted the fix_sdf_exporter branch September 20, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta Targeting beta release of upcoming collection 🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

gz-sim: Blender SDF Exporter
2 participants