Server: explicitly skip auto-inertial calculation #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Automatic inertial calculation may not work in Root::Load, so explicitly configure the loader to skip auto-inertial calculation. Signed-off-by: Steve Peters <[email protected]>
19 tasks
Codecov Report
@@ Coverage Diff @@
## gz-sim8 #2166 +/- ##
===========================================
+ Coverage 65.47% 65.49% +0.01%
===========================================
Files 323 323
Lines 30711 30713 +2
===========================================
+ Hits 20108 20115 +7
+ Misses 10603 10598 -5
|
|
testing with ci_matching_branch in #2170 |
azeey
approved these changes
Sep 27, 2023
mjcarroll
approved these changes
Sep 28, 2023
|
Waiting to test with the sdformat pre-release. |
|
@osrf-jenkins run tests please |
|
LGTM! The failing test on Actions has been fixed on #2175, so I'll merge and do another CI run in the prerelease PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Needed when gazebosim/sdformat#1325 is merged
Summary
Automatic inertial calculation may not work in
Root::Load, so explicitly configure the loader to skip auto-inertial calculation. Computation of auto-inertial values are currently skipped by default, but the default behavior is proposed to be changed in gazebosim/sdformat#1325, after which, this pull request would be required.Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.