-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for sensor pointer null when navsat plugin in included in sdf #2176
Conversation
Signed-off-by: ashbabu <[email protected]>
Signed-off-by: ashbabu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor formatting issues.
Can you also update the title of the PR?
Signed-off-by: ashbabu <[email protected]>
done |
@mjcarroll : I am not sure why some of the checks were unsuccessful. Is there something that I could do to get this approved? Thanks |
I'm still seeing the code not wrapped at 80 characters, that may be triggering a lint failure. I believe the other failures are related to #2190, so you won't need to fix them. |
Signed-off-by: ashbabu <[email protected]>
@osrf-jenkins retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just a minor typo otherwise looks good to me
Co-authored-by: Ian Chen <[email protected]> Signed-off-by: Michael Carroll <[email protected]>
🦟 Bug fix
Fixes #2163
Summary
When the play button is pressed in Gazebo, the terminal window shows an error as described in #2163.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸
Test it
model.sdf
with the followingnavsat
pluginign gazebo model.sdf