Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport test fix to garden #2197

Merged
merged 1 commit into from
Oct 9, 2023
Merged

Backport test fix to garden #2197

merged 1 commit into from
Oct 9, 2023

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Oct 8, 2023

🦟 Bug fix

Backports test fix in 409d8c5 from #2175 to garden

Summary

fix INTEGRATION_save_world's SdfGeneratorFixture.ModelWithNestedIncludes test

Build Status https://build.osrfoundation.org/view/ign-garden/job/ignition_gazebo-ci-gz-sim7-homebrew-amd64/145/

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from iche033 October 8, 2023 06:14
@scpeters scpeters requested a review from mjcarroll as a code owner October 8, 2023 06:14
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 8, 2023
@codecov
Copy link

codecov bot commented Oct 8, 2023

Codecov Report

Merging #2197 (505082c) into gz-sim7 (b0ddc34) will decrease coverage by 0.28%.
Report is 68 commits behind head on gz-sim7.
The diff coverage is 53.52%.

❗ Current head 505082c differs from pull request most recent head 6209149. Consider uploading reports for the commit 6209149 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #2197      +/-   ##
===========================================
- Coverage    65.01%   64.74%   -0.28%     
===========================================
  Files          353      357       +4     
  Lines        28618    29122     +504     
===========================================
+ Hits         18606    18854     +248     
- Misses       10012    10268     +256     
Files Coverage Δ
include/gz/sim/EntityComponentManager.hh 100.00% <ø> (ø)
include/gz/sim/Link.hh 100.00% <ø> (ø)
include/gz/sim/Server.hh 100.00% <ø> (ø)
include/gz/sim/Util.hh 100.00% <ø> (ø)
src/Link.cc 95.09% <100.00%> (+0.32%) ⬆️
src/ServerConfig.cc 83.22% <100.00%> (+0.07%) ⬆️
src/SimulationRunner.cc 90.73% <100.00%> (-0.91%) ⬇️
src/SystemLoader.cc 62.59% <100.00%> (ø)
src/TestFixture.cc 100.00% <100.00%> (ø)
src/gui/QuickStartHandler.cc 82.35% <100.00%> (+1.10%) ⬆️
... and 35 more

... and 1 file with indirect coverage changes

@scpeters scpeters merged commit ba40627 into gz-sim7 Oct 9, 2023
5 checks passed
@scpeters scpeters deleted the scpeters/backport_test_fix branch October 9, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants