Use dart13 packages from stable repository on ci (not focal) #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix enviroment system loading mechanism Currently, there is an issue with the way the Environment loader plugin loads data. In particular it directly writes to the ECM. While this makes sense intuitively, it does not work in practice as the GUI runs on a client process while systems that use it run on the server. This PR fixes this issue by introducing a topic through which the GUI may load Environment Data on the server. Signed-off-by: Arjo Chakravarty <[email protected]> * small changes Signed-off-by: Arjo Chakravarty <[email protected]> * Working on porting the visuals Signed-off-by: Arjo Chakravarty <[email protected]> * Actually send message for loading from ui to environment preload plugin. Visuallization still goes 💥 Signed-off-by: Arjo Chakravarty <[email protected]> * Rewrite EnvironmentVisualization Widget to be simpler. Signed-off-by: Arjo Chakravarty <[email protected]> * fix crashes. Vis still not working Signed-off-by: Arjo Chakravarty <[email protected]> * Get a different 💥 Signed-off-by: Arjo Chakravarty <[email protected]> * Works some times. Signed-off-by: Arjo Chakravarty <[email protected]> * Fixed synchronization issues. Now left with one more crash that needs debugging when "play" is hit. Signed-off-by: Arjo Chakravarty <[email protected]> * No more 💥s 🎉 Signed-off-by: Arjo Chakravarty <[email protected]> * style Signed-off-by: Arjo Chakravarty <[email protected]> * Sprinkled with healthy dose of Doxygen Also refactored the visualization tool out. Signed-off-by: Arjo Chakravarty <[email protected]> * Style Signed-off-by: Arjo Chakravarty <[email protected]> * More style fixes Signed-off-by: Arjo Chakravarty <[email protected]> * Fix Typo with unit map Signed-off-by: Arjo Chakravarty <[email protected]> * Address PR feedback Signed-off-by: Arjo Chakravarty <[email protected]> * Style fixes Signed-off-by: Arjo Chakravarty <[email protected]> * Fix incorrect use of path. Signed-off-by: Arjo Chakravarty <[email protected]> * Fix example loading issues. Signed-off-by: Arjo Chakravarty <[email protected]> * style Signed-off-by: Arjo Chakravarty <[email protected]> * Update src/systems/environment_preload/VisualizationTool.cc Co-authored-by: Mabel Zhang <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> * Adds a warning regarding loading plugins. Signed-off-by: Arjo Chakravarty <[email protected]> * Automatically loads plugin if missing This commit automatically loads the environment preload plugin if it is missing. Signed-off-by: Arjo Chakravarty <[email protected]> * Address some feedback I missed Signed-off-by: Arjo Chakravarty <[email protected]> * Address some feedback Signed-off-by: Arjo Chakravarty <[email protected]> * Fixes issue described by @iche033. However fix depends on gazebosim/gz-math#551 Signed-off-by: Arjo Chakravarty <[email protected]> * style Signed-off-by: Arjo Chakravarty <[email protected]> * Fixed failing tests Signed-off-by: Arjo Chakravarty <[email protected]> --------- Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> Signed-off-by: Arjo Chakravarty <[email protected]> Co-authored-by: Michael Carroll <[email protected]> Co-authored-by: Mabel Zhang <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: frederik <[email protected]>
…des test (#2197) Signed-off-by: Ian Chen <[email protected]> Co-authored-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
|
Not the right branch for Harmonic sorry. Closing and sending a right one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #
Summary
Our stable repository has now dart6.13 packages released for Harmonic. We should be using them instead of system ones.
For focal, we are using the dartsim PPA and we do not have them in our repository so I leave it untouched by now.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.