Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wind addition to advanced_lift_drag plugin #2226

Merged
merged 2 commits into from
Nov 9, 2023

Conversation

frede791
Copy link
Contributor

@frede791 frede791 commented Nov 3, 2023

Summary

This PR enhances the advanced lift drag plugin by taking wind in the environment into account.

Checklist

  • Signed all commits for DCO
  • codecheck passed (See contributing)
  • All tests that passed before pass now and no new failures occur. (See test coverage)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 3, 2023
@frede791 frede791 marked this pull request as ready for review November 3, 2023 15:01
@frede791 frede791 requested a review from mjcarroll as a code owner November 3, 2023 15:01
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #2226 (cf5d170) into gz-sim7 (b8d1679) will increase coverage by 0.00%.
Report is 2 commits behind head on gz-sim7.
The diff coverage is n/a.

❗ Current head cf5d170 differs from pull request most recent head 45fa61b. Consider uploading reports for the commit 45fa61b to get more accurate results

@@           Coverage Diff            @@
##           gz-sim7    #2226   +/-   ##
========================================
  Coverage    64.75%   64.75%           
========================================
  Files          357      357           
  Lines        29144    29143    -1     
========================================
  Hits         18872    18872           
+ Misses       10272    10271    -1     

see 1 file with indirect coverage changes

Copy link
Contributor

@arjo129 arjo129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Might be worth adding a small note in the header saying that you can add wind by setting the wind parameter in the sdf world.

Signed-off-by: frederik <[email protected]>
@frede791
Copy link
Contributor Author

frede791 commented Nov 8, 2023

Added the requested note on wind to the header file.

@arjo129 arjo129 merged commit e88a46f into gazebosim:gz-sim7 Nov 9, 2023
10 of 11 checks passed
@frede791 frede791 deleted the wind_addition branch November 9, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants