Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update friction parameters for skid steer example #2235

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Nov 10, 2023

🦟 Bug fix

Fixes #2174

Summary

As shown in #2174, the vehicle seems to rotate around the center of the rear axle instead of the center of the vehicle. The new friction parameters, which I copied from the examples/worlds/diff_drive.sdf, seem to fix the issue.

@jasiex01 can you give this a try?

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

@azeey azeey requested a review from mjcarroll as a code owner November 10, 2023 17:58
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Nov 10, 2023
@jasiex01
Copy link

Everything works as expected now, closing the issue

@mjcarroll mjcarroll merged commit e0e02c4 into gazebosim:ign-gazebo6 Nov 14, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants