Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EnvironmentPreload: ignerr -> gzerr #2245

Merged
merged 1 commit into from
Nov 14, 2023
Merged

Conversation

scpeters
Copy link
Member

🦟 Bug fix

Fixes an ignerr instance on gz-sim7

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@scpeters scpeters requested a review from mjcarroll as a code owner November 13, 2023 22:09
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (409efa7) 64.74% compared to head (4e9ab5c) 64.76%.

❗ Current head 4e9ab5c differs from pull request most recent head 205d9dd. Consider uploading reports for the commit 205d9dd to get more accurate results

Files Patch % Lines
.../systems/environment_preload/EnvironmentPreload.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim7    #2245      +/-   ##
===========================================
+ Coverage    64.74%   64.76%   +0.01%     
===========================================
  Files          357      357              
  Lines        29139    29138       -1     
===========================================
+ Hits         18867    18872       +5     
+ Misses       10272    10266       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mjcarroll mjcarroll merged commit c73c12b into gz-sim7 Nov 14, 2023
10 of 11 checks passed
@mjcarroll mjcarroll deleted the scpeters/fix_ignerr_7 branch November 14, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants