environment_preload: fix windows compiler warnings #2246
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes some compiler warnings in windows CI from the
environment_preload
systemSummary
The garden windows CI build has no test failures and just a few compiler warnings:
This is an attempt to fix the compiler warnings in the
environment_preload
system, specifically VisualizationTool.cc:80.From what I can see, the
/environment/visualize/res
topic uses agz::msgs::Vector3d
to store 3 integers because there is nogz::msgs::Vector3i
. This PR casts thedouble
values tounsigned int
in the callback and changes the internal storage and APIs to useunsigned int
instead ofdouble
.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.