Fix DLL linkage/visibility issues #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Carroll <[email protected]>
ahcorde
previously requested changes
Nov 21, 2023
Signed-off-by: Michael Carroll <[email protected]>
|
There is a failing Windows test here, but the linkage warning are gone. |
scpeters
approved these changes
Nov 21, 2023
mjcarroll
added a commit
that referenced
this pull request
Jun 24, 2024
Signed-off-by: Michael Carroll <[email protected]>
azeey
pushed a commit
that referenced
this pull request
Jul 10, 2024
Signed-off-by: Michael Carroll <[email protected]>
azeey
pushed a commit
that referenced
this pull request
Jul 11, 2024
Signed-off-by: Michael Carroll <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was caused by rebuilding the same file as a library and standalone executable. This simply separates the two.
Closes #2251