-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set max contacts for collision pairs #2270
Conversation
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
Signed-off-by: Ian Chen <[email protected]>
@caguero to make a release of gz-physics6 to unblock this PR. |
Hi, when I run this example in Gazebo Harmonic, i don't get the "after" result with only 20 contacts. It still appears as the before result. This is true if I explicitly state the <max_contacts> in the world file as well. I am running gz physics from ROS2 installed vendor packages which appears to be the latest release (gz-physics 7.2.0). From a look at the gz-physics repo, max_contacts appears to be implemented.. has this feature indeed been released? Am I missing something? -User |
we still need to merge this PR, forward port to the |
Thanks for the info. If I wanted to use this feature in advance of its official release, do you know how I would go about that? If I'm reading this PR and status board correctly, it looks like this feature has been merged into gz-sim7 (Garden). I have installed both the stable and nightly binary releases of Garden in a container. The gz-physics6 version installed in the container is 6.6.0. I am assuming this corresponds to the gz-physics6 branch of the github repo. However, I still can't run the new feature. Can you point me in the right direction? |
The changes in gz-sim7 has not been released yet. To test this you'll need to build gz-sim7 from source I don't think we are currently building nightlies for gz-sim7 so I think the gz-sim7 nightly you have is probably quite old now. |
🎉 New feature
Depends on gazebosim/gz-physics#582
Summary
Set max_contacts physics parameter in physics engines that support this feature. See gazebosim/gz-physics#582 for support in dartsim's ode collision detector.
Test it
Here's an example test world: contacts.sdf.
The test world has a large box with an ellipsoid inside. The contact points are visualized in blue:
Before: No max contacts set. Many contacts detected. Low RTF (~30%)
After: Max contacts set based on SDF default value (20). Limited to 20 contacts. High RTF (~9X%)
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.