Add entity validation to OdometryPublisher #2326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anton Bogdanov <[email protected]>
azeey
reviewed
Mar 1, 2024
Signed-off-by: Anton Bogdanov <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gz-sim8 #2326 +/- ##
===========================================
- Coverage 65.97% 65.95% -0.02%
===========================================
Files 327 327
Lines 31328 31332 +4
===========================================
- Hits 20668 20665 -3
- Misses 10660 10667 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Anton Bogdanov <[email protected]>
Signed-off-by: Anton Bogdanov <[email protected]>
azeey
approved these changes
Mar 1, 2024
There was a problem hiding this comment.
Thanks! If you're interested in contributing more, which we'd love, please take a look at these good first issues
|
@azeey Any idea when this would be released? |
|
We'll shoot for making a release this week. |
|
Awesome. Thanks for the heads up 👍 |
GauravKumar9920
pushed a commit
to GauravKumar9920/gz-sim
that referenced
this pull request
Mar 30, 2024
Until SystemManager has the ability to unload system plugins, plugins require an explicit check of the validity of the entities used in the Update methods. Such a check was missing in OdometryPublisher, which led to non-critical but annoying errors in the console. --------- Signed-off-by: Anton Bogdanov <[email protected]> Signed-off-by: Gaurav Kumar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Until SystemManager has the ability to unload system plugins, plugins require an explicit check of the validity of the entities used in the Update methods. Such a check was missing in OdometryPublisher, which led to non-critical but annoying errors in the console.
P.S. It's my first PR to open source project, sorry if i missing something