-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Track and Follow options in gui EntityContextMenu #2402
Conversation
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
Signed-off-by: Benjamin Perseghetti <[email protected]>
4c5879e
to
a1a384a
Compare
Co-authored-by: Alejandro Hernández Cordero <[email protected]> Signed-off-by: Benjamin Perseghetti <[email protected]>
4346c28
to
96b602a
Compare
Signed-off-by: Benjamin Perseghetti <[email protected]>
Co-authored-by: Jenn Nguyen <[email protected]> Signed-off-by: Benjamin Perseghetti <[email protected]>
@osrf-jenkins run tests |
1 similar comment
@osrf-jenkins run tests |
Dismissed review as all requested changes were made.
I accidentally upgraded to 8.4.0 today. This feature is giving me some problems. The popup window Follow command does not seem to do anything anymore. Is there a new dependency that is needed for this to work? The 'Move To' command works but follow does not when it previously did. Using the Right click on the Entity Tree. Then the popup window selecting the Follow Options -> Follow I'm experimenting with using docker to run some ardupilot simulations. Below is the Dockerfile. (Rebuilding the docker image is how I accidentally upgraded). I am using harmonic and humble Also is there an easy way to revert to 8.3.0?
|
@iche033 I think this is what I mentioned to you yesterday about not having it in first but releasing a gz-sim. |
@nosradom fix is incoming and should be released to binaries soon. |
Awesome thanks |
Were you able to update and make sure it works properly in your environment? |
🎉 New feature
Summary
I would like to thank NXP for their support in enabling this work.
Depends on:
This adds a new
/gui/track
topic using the CameraTrack message to control multiple types of tracking and associated pgain(s), target(s) and offset(s). Furthermore it publishes a tracking camera status CameraTrack message on/gui/currently_tracked
This also adds an 3 unique follow modes and a tracking mode all able to be set from either the
/gui/track
topic or more ideally from the user gui.The 3 follow modes are in a submenu under the right click top level menu
Follow Options >
and are:Follow - Traditional follow mode where camera follows and tracks the same target.
Free Look - Enables a user to follow a target while still using an input device (IE mouse) to look around.
Look At - Only enabled after already selecting a primary object to follow, this allows a user to track a unique secondary target while following the primary target.
The other right click top level menu item added is
Track
, where the gui camera can be moved anywhere in the simulator but will always track the selected object.These all respect using the escape key to stop any form of tracking.
Test it
Use these changes for collection-harmonic.yaml:
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.