Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sensors with pending trigger immediately in Sensors system #2408

Merged
merged 1 commit into from
May 28, 2024
Merged

Update sensors with pending trigger immediately in Sensors system #2408

merged 1 commit into from
May 28, 2024

Conversation

shameekganguly
Copy link
Contributor

🦟 Bug fix

Fixes gazebosim/gz-sensors#426

Summary

Update Sensors system to ignore update rate for sensors that have pending triggers and update them immediately. Depends on upstream gazebosim/gz-sensors#431.

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@shameekganguly shameekganguly added the needs upstream release Blocked by a release of an upstream library label May 14, 2024
@shameekganguly shameekganguly requested a review from iche033 as a code owner May 14, 2024 23:20
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 14, 2024
Copy link

codecov bot commented May 15, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.92%. Comparing base (922eea7) to head (d8d351d).
Report is 168 commits behind head on gz-sim8.

Files Patch % Lines
src/systems/sensors/Sensors.cc 85.71% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim8    #2408      +/-   ##
===========================================
+ Coverage    64.88%   65.92%   +1.03%     
===========================================
  Files          360      327      -33     
  Lines        29448    31328    +1880     
===========================================
+ Hits         19108    20653    +1545     
- Misses       10340    10675     +335     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@azeey azeey self-requested a review May 22, 2024 18:34
@iche033 iche033 removed the needs upstream release Blocked by a release of an upstream library label May 28, 2024
@ahcorde ahcorde merged commit 8713f04 into gazebosim:gz-sim8 May 28, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Improve support for triggered cameras
3 participants