Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing algorithm include #2414

Merged
merged 1 commit into from
May 24, 2024
Merged

Add missing algorithm include #2414

merged 1 commit into from
May 24, 2024

Conversation

oysstu
Copy link
Contributor

@oysstu oysstu commented May 24, 2024

🦟 Bug fix

Fixes #2413

Summary

Needed due to use of std::find_if in Factory.hh.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

@oysstu
Add missing algorithm include
9ec1a3c 
Needed due to use of std::find_if.

Signed-off-by: Øystein Sture <[email protected]>
@oysstu oysstu requested a review from mjcarroll as a code owner May 24, 2024 20:14
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label May 24, 2024
@azeey azeey merged commit 40aaddc into gazebosim:gz-sim8 May 24, 2024
8 of 9 checks passed
@e8035669 e8035669 mentioned this pull request Sep 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees
No one assigned
Labels
🎵 harmonic Gazebo Harmonic
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing include algorithm in header (Factory.hh)
2 participants
@oysstu @azeey