Support mesh optimization when using AttachMeshShapeFeature #2417
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Summary
Add mesh optimization support in dartsim.
Dartsim uses
AttachMeshShapeFeature
for constructing meshes. It expects acommon::Mesh
to already be loaded and passed to it. So we need to optimize the mesh first in gz-sim (instead of doing mesh optimization inside gz-physics dartsim plugin). To support this, this PR adds logic to perform mesh optimization whenever a mesh is being loaded (e.g. vialoadMesh
here in physics system).Test it
You can test with the cordless drill simplified mesh. Here's a cordless_drill.sdf test world
Launch gz-sim with the optimized mesh
and you should see a debug msg like this:
Mesh collision visualization support is in #2352. I'll refactor that PR to use the new
optimizeMesh
function introduced here once this PR gets in.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.