Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a few extra zeros from some sdf files #2426

Merged
merged 1 commit into from
May 31, 2024

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented May 31, 2024

🦟 Bug fix

Summary

Just removing a few extra zeros from a few SDF files.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig requested a review from mjcarroll as a code owner May 31, 2024 12:50
@github-actions github-actions bot added the 🌱 garden Ignition Garden label May 31, 2024
Copy link

codecov bot commented May 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.02%. Comparing base (5a76b28) to head (339e681).
Report is 15 commits behind head on gz-sim7.

Additional details and impacted files
@@             Coverage Diff             @@
##           gz-sim7    #2426      +/-   ##
===========================================
+ Coverage    64.72%   65.02%   +0.30%     
===========================================
  Files          357      361       +4     
  Lines        29160    29624     +464     
===========================================
+ Hits         18874    19264     +390     
- Misses       10286    10360      +74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@iche033 iche033 merged commit bd1d057 into gz-sim7 May 31, 2024
11 checks passed
@iche033 iche033 deleted the nkoenig/remove-extra-zero-test-sdf branch May 31, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants