Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModelCommandAPI unit test #2444

Merged
merged 1 commit into from
Jun 15, 2024
Merged

Fix ModelCommandAPI unit test #2444

merged 1 commit into from
Jun 15, 2024

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 14, 2024

🦟 Bug fix

Summary

Fixed test by updating the expected model command output string - the skew value changed from 1 to 0 in gazebosim/sdformat#1423

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 requested a review from mjcarroll as a code owner June 14, 2024 21:39
@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Jun 14, 2024
@iche033 iche033 merged commit ed2b64c into gz-sim8 Jun 15, 2024
9 checks passed
@iche033 iche033 deleted the fix_modelcommandapi_tet branch June 15, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants