Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics: Ray intersections #2514

Open
wants to merge 3 commits into
base: gz-sim8
Choose a base branch
from

Conversation

romulogcerqueira
Copy link

@romulogcerqueira romulogcerqueira commented Aug 5, 2024

🎉 New feature

Related to gazebosim/gz-sensors#26 and gazebosim/gz-physics#641

Summary

This PR introduces components to hold rays and ray intersections data (MultiRay and MultiRayIntersections, respectively), and updates the physics system to compute the ray castings during Update loop.

Test it

Added a test case to physics system.

Build and run ./build/bin/INTEGRATION_physics_system --gtest_filter=PhysicsSystemFixture.RayIntersections

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@github-actions github-actions bot added the 🎵 harmonic Gazebo Harmonic label Aug 5, 2024
@romulogcerqueira romulogcerqueira force-pushed the romulogcerqueira/ray_intersections branch 2 times, most recently from 3d1dc26 to 815c56b Compare August 5, 2024 17:17
Rômulo Cerqueira added 3 commits August 5, 2024 23:57
@romulogcerqueira romulogcerqueira force-pushed the romulogcerqueira/ray_intersections branch from 815c56b to e9c3a9a Compare August 6, 2024 02:58
@azeey
Copy link
Contributor

azeey commented Aug 6, 2024

Thanks for the PR! However, as stated in https://community.gazebosim.org/t/feature-freeze-for-gazebo-ionic/2900/2, we are now in feature freeze and will not review/merge any new PRs until after Ionic is released at the end of September. I hope you'll be able to iterate on the PR then.

@romulogcerqueira
Copy link
Author

Thanks for the PR! However, as stated in https://community.gazebosim.org/t/feature-freeze-for-gazebo-ionic/2900/2, we are now in feature freeze and will not review/merge any new PRs until after Ionic is released at the end of September. I hope you'll be able to iterate on the PR then.

Thanks for the message, @azeey .

One question: Will all new features be redirected to Ionic, or will we maintain backward compatibility with Harmonic, since the latter is LTS?

@azeey
Copy link
Contributor

azeey commented Aug 9, 2024

One question: Will all new features be redirected to Ionic, or will we maintain backward compatibility with Harmonic, since the latter is LTS?

Once Ionic is released, we'll ask folks to target PRs to Ionic branches and the core team will backport to older release on a best-effort basis. Of course, you are welcome to backport it yourself. See https://community.gazebosim.org/t/gazebo-policy-update-new-backporting-policy/2880 for more details.

@huqin-RM
Copy link

huqin-RM commented Nov 20, 2024

I want this function because I want to realize the livox 360 radar simulation. This radar is spiral scanning, and gpu_ray cannot realize this. So when will this function be implemented? @azeey @romulogcerqueira

e1161b76-f3eb-4491-bd6c-2a62b4d7aa21.2._an.1.mp4

@ntfshard
Copy link
Contributor

It also can be useful for our use-cases I suppose. I guess this branch should be re-targeted on a last branch

@huqin-RM
Copy link

@romulogcerqueira Will this feature be pushed forward to the official version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎵 harmonic Gazebo Harmonic
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

4 participants