-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physics: Ray intersections #2514
base: gz-sim8
Are you sure you want to change the base?
Physics: Ray intersections #2514
Conversation
3d1dc26
to
815c56b
Compare
Signed-off-by: Rômulo Cerqueira <[email protected]>
Signed-off-by: Rômulo Cerqueira <[email protected]>
Signed-off-by: Rômulo Cerqueira <[email protected]>
815c56b
to
e9c3a9a
Compare
Thanks for the PR! However, as stated in https://community.gazebosim.org/t/feature-freeze-for-gazebo-ionic/2900/2, we are now in feature freeze and will not review/merge any new PRs until after Ionic is released at the end of September. I hope you'll be able to iterate on the PR then. |
Thanks for the message, @azeey . One question: Will all new features be redirected to Ionic, or will we maintain backward compatibility with Harmonic, since the latter is LTS? |
Once Ionic is released, we'll ask folks to target PRs to Ionic branches and the core team will backport to older release on a best-effort basis. Of course, you are welcome to backport it yourself. See https://community.gazebosim.org/t/gazebo-policy-update-new-backporting-policy/2880 for more details. |
I want this function because I want to realize the livox 360 radar simulation. This radar is spiral scanning, and gpu_ray cannot realize this. So when will this function be implemented? @azeey @romulogcerqueira e1161b76-f3eb-4491-bd6c-2a62b4d7aa21.2._an.1.mp4 |
It also can be useful for our use-cases I suppose. I guess this branch should be re-targeted on a last branch |
@romulogcerqueira Will this feature be pushed forward to the official version? |
🎉 New feature
Related to gazebosim/gz-sensors#26 and gazebosim/gz-physics#641
Summary
This PR introduces components to hold rays and ray intersections data (
MultiRay
andMultiRayIntersections
, respectively), and updates the physics system to compute the ray castings duringUpdate
loop.Test it
Added a test case to physics system.
Build and run
./build/bin/INTEGRATION_physics_system --gtest_filter=PhysicsSystemFixture.RayIntersections
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.