Remove detachable joints when a model is removed #2686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Partially fixes #2624
Summary
Remove detachable joints from the ECM when a model is removed. The physics engine will then also remove any associated detachable joint physics objects. I also made a change in physics system to let physics engine remove the detachable joints first before models.
Now when you delete a model, the detachable joints should be deleted causing objects to be detached.
To test:
launch
detachable_joint.sdf
worldDelete
vehicle_blue
and the breadcrumbs should now fall to the ground.Try resetting the world it should no longer crash (#2624). However, the breadcrumbs remain detached, which I think it's a separate issue related to reset.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.