Merge gz-transport13 ➡️ main #479

scpeters · 2024-02-06T19:55:41Z

➡️ Forward port

Port gz-transport13 ➡️ main

Branch comparison: main...gz-transport13

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

Signed-off-by: Addisu Z. Taddese <[email protected]>

Signed-off-by: Voldivh <[email protected]>

Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>

Adds the python bindings tutorial

* Use on `push` only on stable branches to avoid duplicate runs * Update project automation Signed-off-by: Addisu Z. Taddese <[email protected]>

This reworks all of the gz-transport tests to use Subprocess from gz-utils. Signed-off-by: Michael Carroll <[email protected]>

Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Carlos Agüero <[email protected]>

Signed-off-by: Ian Chen <[email protected]>

Signed-off-by: Michael Carroll <[email protected]>

Signed-off-by: Addisu Z. Taddese <[email protected]>

Merge ign-transport8 ➡️ ign-transport11

Signed-off-by: Addisu Z. Taddese <[email protected]>

Merge ign-transport11 ➡️ gz-transport12

Signed-off-by: Michael Carroll <[email protected]>

* Support request/advertise within the same process. Signed-off-by: Carlos Agüero <[email protected]> --------- Signed-off-by: Carlos Agüero <[email protected]>

Signed-off-by: Carlos Agüero <[email protected]>

Signed-off-by: Michael Carroll <[email protected]>

Merge 12 ➡️ 13

This removes the use of gz-cmake's GzPython in favor of a single call to find_package(Python3). This allows setting Python3_EXECUTABLE to specify which python version to use and is needed on macOS. Signed-off-by: Steve Peters <[email protected]>

Signed-off-by: Steve Peters <[email protected]>

mjcarroll · 2024-02-07T00:30:16Z

src/cmd/gz_TEST.cc

@@ -304,23 +304,26 @@ TEST(gzTest, TopicPublish)
    "-t", "/bar",
    "-m", "gz.msgs.__bad_msg_type",
    "-p", R"(data: "good_value")"});
-  EXPECT_EQ(output.cerr.compare(0, error.size(), error), 0);
+  EXPECT_EQ(output.cerr.compare(0, error.size(), error), 0)


Just a note that I have caught a few tests where we previously expected something on cout was now on cerr or vice-versa, but we only parsed the combined output before.

I'm seeing a lot of these failures in UNIT_gz_TEST are caused by the following unexpected console output on Ubuntu 22.04 CI: Library error: libgz-tools2-backward.so.2.0.0 not found. Improved backtrace generation will be disabled. I believe it is a consequence of gazebosim/gz-tools#133 and think I know how to fix it

I updated the debian metadata in gazebo-release/gz-tools2-release#15 and new nightlies have been rebuilt and the tests are now passing

scpeters · 2024-02-08T17:05:06Z

@osrf-jenkins run tests please

codecov · 2024-02-08T17:37:44Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.64%. Comparing base (94b335f) to head (9aaa434).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #479      +/-   ##
==========================================
- Coverage   87.80%   87.64%   -0.17%     
==========================================
  Files          59       59              
  Lines        5699     5704       +5     
==========================================
- Hits         5004     4999       -5     
- Misses        695      705      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

scpeters · 2024-02-08T17:53:46Z

looks like CI is happy now, aside from coverage

azeey · 2024-02-09T14:47:55Z

README.md

-Ubuntu Focal | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-main-focal-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-main-focal-amd64)
-Homebrew      | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ignition_transport-ci-main-homebrew-amd64)](https://build.osrfoundation.org/job/ignition_transport-ci-main-homebrew-amd64)
-Windows       | [![Build Status](https://build.osrfoundation.org/buildStatus/icon?job=ign_transport-ci-win)](https://build.osrfoundation.org/job/ign_transport-ci-win/)
+Test coverage | [![codecov](https://codecov.io/gh/gazebosim/gz-transport/tree/gz-transport13/graph/badge.svg)](https://codecov.io/gh/gazebosim/gz-transport/tree/gz-transport13)


The branch names should still be main.

fixed in 9aaa434

src/cmd/gz_TEST.cc

Signed-off-by: Ian Chen <[email protected]>

iche033 · 2024-03-14T18:27:37Z

@caguero is the playback.ReplayStep test failure on windows expected / flaky?

caguero · 2024-03-14T21:21:18Z

@caguero is the playback.ReplayStep test failure on windows expected / flaky?

I think it's flaky, I've seen it fail before.

azeey and others added 27 commits September 1, 2023 09:24

Prepare for 11.4.1 release (#436)

69e9592

Signed-off-by: Addisu Z. Taddese <[email protected]>

Adds the python tutorial for the bindings

da3094b

Signed-off-by: Voldivh <[email protected]>

Address review comments

80212ae

Signed-off-by: Voldivh <[email protected]>

Adds the required snippet tags to the examples

d1de32d

Signed-off-by: Voldivh <[email protected]>

Shortens a couple of lines

b774eb6

Signed-off-by: Voldivh <[email protected]>

Uses capital P on Python

e407bf5

Signed-off-by: Voldivh <[email protected]>

Fixes some grammar

46e050b

Signed-off-by: Voldivh <[email protected]>

Adds the subcommands for the log command (#451)

ce66a7c

Signed-off-by: Voldivh <[email protected]>

Remove duplicated functionality from test_config (#457)

c6be5a2

Signed-off-by: Michael Carroll <[email protected]> Co-authored-by: Alejandro Hernández Cordero <[email protected]>

Merge pull request #450 from gazebosim/voldivh/python_tutorial

6c4b1ec

Adds the python bindings tutorial

Update github action workflows (#460)

3d0cf67

* Use on `push` only on stable branches to avoid duplicate runs * Update project automation Signed-off-by: Addisu Z. Taddese <[email protected]>

Use subprocess rather than custom code (#429)

290055f

This reworks all of the gz-transport tests to use Subprocess from gz-utils. Signed-off-by: Michael Carroll <[email protected]>

Support for bazel on garden (#399)

1db0afe

Signed-off-by: Michael Carroll <[email protected]> Signed-off-by: Carlos Agüero <[email protected]> Co-authored-by: Carlos Agüero <[email protected]>

Update CI badges in README (#465)

764a04b

Signed-off-by: Ian Chen <[email protected]>

🎈 8.5.0 (#466)

db86f9b

Signed-off-by: Michael Carroll <[email protected]>

Merge 8 to 11

2bd21ff

Signed-off-by: Addisu Z. Taddese <[email protected]>

Merge pull request #469 from azeey/8_to_11

b0328a1

Merge ign-transport8 ➡️ ign-transport11

Merge 11 into 12

ca954cb

Signed-off-by: Addisu Z. Taddese <[email protected]>

Merge pull request #471 from azeey/11_to_12

e7c3292

Merge ign-transport11 ➡️ gz-transport12

Test refactoring part 2 (#463)

92d02dc

Signed-off-by: Michael Carroll <[email protected]>

Fix issue #468 (#470)

3a34f07

* Support request/advertise within the same process. Signed-off-by: Carlos Agüero <[email protected]> --------- Signed-off-by: Carlos Agüero <[email protected]>

Merge branch 'gz-transport12' into 12_13

b4d6377

Play with tests

157311e

Signed-off-by: Carlos Agüero <[email protected]>

Fix test executable name

eac2e69

Signed-off-by: Michael Carroll <[email protected]>

Merge pull request #478 from gazebosim/12_13

5ec65e2

Merge 12 ➡️ 13

Merge branch 'gz-transport13' into scpeters/merge_13_main

4bf2998

scpeters requested a review from caguero as a code owner February 6, 2024 19:55

github-actions bot added the 🏛️ ionic Gazebo Ionic label Feb 6, 2024

gz_TEST: more output when tests fail (#479)

251b9bd

Signed-off-by: Steve Peters <[email protected]>

mjcarroll reviewed Feb 7, 2024

View reviewed changes

This was referenced Feb 7, 2024

gz-tools.install: install libs with soversion gazebo-release/gz-tools2-release#15

Merged

Add project soversion information to backward library gazebosim/gz-tools#133

Merged

azeey reviewed Feb 9, 2024

View reviewed changes

scpeters mentioned this pull request Feb 9, 2024

Cherry-pick #472 to main: Find Python3 directly, not with GzPython #480

Merged

Merge branch 'main' into scpeters/merge_13_main

9aaa434

Signed-off-by: Ian Chen <[email protected]>

caguero approved these changes Mar 14, 2024

View reviewed changes

iche033 approved these changes Mar 14, 2024

View reviewed changes

iche033 merged commit 63ee52c into main Mar 14, 2024
6 of 8 checks passed

iche033 deleted the scpeters/merge_13_main branch March 14, 2024 21:44

iche033 mentioned this pull request Mar 16, 2024

Merge 8 -> main gazebosim/gz-sim#2334

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge gz-transport13 ➡️ main #479

Merge gz-transport13 ➡️ main #479

scpeters commented Feb 6, 2024

mjcarroll Feb 7, 2024

scpeters Feb 7, 2024

scpeters Feb 8, 2024

scpeters commented Feb 8, 2024

codecov bot commented Feb 8, 2024 •

edited

Loading

scpeters commented Feb 8, 2024

azeey Feb 9, 2024

iche033 Mar 14, 2024

iche033 commented Mar 14, 2024

caguero commented Mar 14, 2024

Merge gz-transport13 ➡️ main #479

Merge gz-transport13 ➡️ main #479

Conversation

scpeters commented Feb 6, 2024

➡️ Forward port

mjcarroll Feb 7, 2024

Choose a reason for hiding this comment

scpeters Feb 7, 2024

Choose a reason for hiding this comment

scpeters Feb 8, 2024

Choose a reason for hiding this comment

scpeters commented Feb 8, 2024

codecov bot commented Feb 8, 2024 • edited Loading

Codecov Report

scpeters commented Feb 8, 2024

azeey Feb 9, 2024

Choose a reason for hiding this comment

iche033 Mar 14, 2024

Choose a reason for hiding this comment

iche033 commented Mar 14, 2024

caguero commented Mar 14, 2024

codecov bot commented Feb 8, 2024 •

edited

Loading