Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clang-tidy and include-what-you-use warnings #107

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Sep 21, 2023

Will also bump subprocess.h when this lands: sheredom/subprocess.h#75

@mjcarroll mjcarroll requested a review from azeey as a code owner September 21, 2023 13:36
@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Merging #107 (8aa1fd3) into gz-utils2 (a962cb2) will not change coverage.
The diff coverage is n/a.

❗ Current head 8aa1fd3 differs from pull request most recent head 70d90e7. Consider uploading reports for the commit 70d90e7 to get more accurate results

@@            Coverage Diff             @@
##           gz-utils2     #107   +/-   ##
==========================================
  Coverage      79.45%   79.45%           
==========================================
  Files              8        8           
  Lines            331      331           
==========================================
  Hits             263      263           
  Misses            68       68           
Files Coverage Δ
cli/include/gz/utils/cli/GzFormatter.hpp 88.13% <ø> (ø)
src/Environment.cc 95.23% <ø> (ø)

@mjcarroll mjcarroll mentioned this pull request Sep 26, 2023
@mjcarroll mjcarroll requested a review from ahcorde October 4, 2023 15:04
@mjcarroll mjcarroll self-assigned this Oct 4, 2023
@azeey
Copy link
Contributor

azeey commented Oct 12, 2023

DCO is failing

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll force-pushed the mjcarroll/misc_cleanup branch from 6203fc7 to 70d90e7 Compare October 12, 2023 22:30
@mjcarroll mjcarroll merged commit 7b3da59 into gz-utils2 Oct 13, 2023
8 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/misc_cleanup branch October 13, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants