Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add license checking support to bazel #108

Merged
merged 11 commits into from
Oct 31, 2023
Merged

Add license checking support to bazel #108

merged 11 commits into from
Oct 31, 2023

Conversation

mjcarroll
Copy link
Contributor

No description provided.

@mjcarroll
Not sure why this was here, but it is unused
1946f2e 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Ensure all licenses are reflected in top-level
4278a00 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Include what you use
916dcbc 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Additional iwyu
a7cf0d6 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Drop license comment from bazel
f917b28 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Add license checking support to bazel rules
7d160bb 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Lint
18e6620 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Add dep
fb1696f 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll requested a review from azeey as a code owner September 21, 2023 14:10
@codecov
Copy link

codecov bot commented Sep 21, 2023 •
edited
Loading

Codecov Report

Merging #108 (69b2433) into gz-utils2 (7b3da59) will not change coverage.
The diff coverage is n/a.

❗ Current head 69b2433 differs from pull request most recent head a3df176. Consider uploading reports for the commit a3df176 to get more accurate results

@@            Coverage Diff             @@
##           gz-utils2     #108   +/-   ##
==========================================
  Coverage      79.45%   79.45%           
==========================================
  Files              8        8           
  Lines            331      331           
==========================================
  Hits             263      263           
  Misses            68       68

@mjcarroll mjcarroll mentioned this pull request Sep 26, 2023
Merged
@mjcarroll mjcarroll self-assigned this Oct 4, 2023
@mjcarroll mjcarroll force-pushed the mjcarroll/misc_cleanup branch from 6203fc7 to 70d90e7 Compare October 12, 2023 22:30
Base automatically changed from mjcarroll/misc_cleanup to gz-utils2 October 13, 2023 14:39
azeey
azeey approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@azeey azeey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small comment, otherwise LGTM!

cli/BUILD.bazel Outdated Show resolved Hide resolved
@mjcarroll
Use cli license
21e7da0 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Merge branch 'gz-utils2' into mjcarroll/license
1adede7 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Add license entry
a3df176 
Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll mjcarroll merged commit 36172b7 into gz-utils2 Oct 31, 2023
8 checks passed
@mjcarroll mjcarroll deleted the mjcarroll/license branch October 31, 2023 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azeey azeey azeey approved these changes

Assignees

@mjcarroll mjcarroll

Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjcarroll @azeey