Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable HIDE_SYMBOLS_BY_DEFAULT #116

Closed
wants to merge 1 commit into from
Closed

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Nov 6, 2023

🎉 New feature

Summary

Use the hidden visibility by default in preparation to make the change generally on Ionic using Part of gazebosim/gz-cmake#166

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero requested a review from azeey as a code owner November 6, 2023 18:12
Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #116 (bc82919) into main (32e4019) will not change coverage.
The diff coverage is n/a.

❗ Current head bc82919 differs from pull request most recent head 513c4e2. Consider uploading reports for the commit 513c4e2 to get more accurate results

@@           Coverage Diff           @@
##             main     #116   +/-   ##
=======================================
  Coverage   80.11%   80.11%           
=======================================
  Files           8        8           
  Lines         342      342           
=======================================
  Hits          274      274           
  Misses         68       68           

@azeey
Copy link
Contributor

azeey commented Nov 6, 2023

I think this is a duplicate of #115.

@j-rivero
Copy link
Contributor Author

j-rivero commented Nov 6, 2023

I think this is a duplicate of #115.

arg, sorry.

@j-rivero j-rivero closed this Nov 6, 2023
@scpeters scpeters deleted the jrivero/hidden_symbols branch November 6, 2023 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants