Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use common formatter for console and file sinks #141

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Aug 28, 2024

🦟 Bug fix

Fixes #

Summary

The severity level of the file sink is now set to trace so that it logs to file regardless of the severity level of the console.

This patch also adds an API to set the severity level of just the console sink.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

The severity level of the file sink is now set to trace so that
it logs to file regardless of the severity level of the console.

This patch also adds an API to set the severity level of just the
console sink.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from caguero August 28, 2024 19:20
@caguero caguero merged commit f5eabdf into gazebosim:gz-utils3 Aug 28, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants