Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ign -> gz Macro Migration : gz-utils #64

Merged
merged 3 commits into from
Jun 17, 2022
Merged

ign -> gz Macro Migration : gz-utils #64

merged 3 commits into from
Jun 17, 2022

Conversation

methylDragon
Copy link
Contributor

@methylDragon methylDragon requested a review from azeey as a code owner June 6, 2022 21:41
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Jun 6, 2022
@methylDragon methylDragon mentioned this pull request Jun 6, 2022
Closed
@codecov
Copy link

codecov bot commented Jun 6, 2022 •
edited
Loading

Codecov Report

Merging #64 (7f26175) into main (f950fed) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #64   +/-   ##
=======================================
  Coverage   41.04%   41.04%           
=======================================
  Files          17       17           
  Lines        2334     2334           
=======================================
  Hits          958      958           
  Misses       1376     1376
Impacted Files Coverage Δ
cli/include/gz/utils/cli/GzFormatter.hpp 88.13% <ø> (ø)
include/gz/utils/ImplPtr.hh 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f950fed...7f26175. Read the comment docs.

scpeters
scpeters reviewed Jun 6, 2022
View reviewed changes
Migration.md Show resolved Hide resolved
@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Jun 7, 2022
chapulina
chapulina approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but merging this will break all downstream libraries, because they're already using the gz headers. So let's wait to merge everything in sync.

@chapulina chapulina enabled auto-merge (squash) June 17, 2022 20:48
@chapulina chapulina merged commit 3463812 into main Jun 17, 2022
@chapulina chapulina deleted the macro_migration branch June 17, 2022 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@scpeters scpeters scpeters left review comments

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden ign to gz Renaming Ignition to Gazebo.
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@methylDragon @scpeters @chapulina