Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor battery demo #633

Merged
merged 11 commits into from
Dec 16, 2024
Merged

Refactor battery demo #633

merged 11 commits into from
Dec 16, 2024

Conversation

caguero
Copy link
Contributor

@caguero caguero commented Nov 5, 2024

Refactors the battery demo leveraging the latest improvements in ros_gz.

  • I replaced the logic to spawn the bridge using the RosGzBridge action.
  • I left the example in Python and using Gazebo for being able to use the -z 1000000 flag.

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
Signed-off-by: Carlos Agüero <[email protected]>
@caguero caguero changed the title Battery demo refactor Refactor battery demo Nov 6, 2024
@caguero caguero marked this pull request as ready for review November 22, 2024 20:40
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not the xml version ?

@caguero
Copy link
Contributor Author

caguero commented Nov 25, 2024

why not the xml version ?

We're launching Gazebo with -z 1000000. If we move to XML we cannot support it.

@caguero caguero requested a review from ahcorde December 11, 2024 16:13
Copy link
Collaborator

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Launch is a Python file no a xml

@ahcorde ahcorde merged commit 5e0c49b into ros2 Dec 16, 2024
5 checks passed
@ahcorde ahcorde deleted the caguero/battery_demo_v2 branch December 16, 2024 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants