Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy 1.11 spec to 1.12 for libsdformat15 #1375

Merged
merged 3 commits into from
Feb 28, 2024
Merged

Copy 1.11 spec to 1.12 for libsdformat15 #1375

merged 3 commits into from
Feb 28, 2024

Conversation

scpeters
Copy link
Member

🎉 New feature

Needed for Ionic features

Summary

This bumps the SDFormat spec version to 1.12 on main so we can add new features for Ionic. There are not yet any changes between 1.11 and 1.12.

Test it

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <[email protected]>
Signed-off-by: Steve Peters <[email protected]>
@scpeters scpeters requested a review from azeey as a code owner February 27, 2024 22:48
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Feb 27, 2024
Copy link

codecov bot commented Feb 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.42%. Comparing base (ca74234) to head (e26890f).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1375   +/-   ##
=======================================
  Coverage   92.42%   92.42%           
=======================================
  Files         134      134           
  Lines       17707    17707           
=======================================
  Hits        16365    16365           
  Misses       1342     1342           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scpeters scpeters merged commit b79abc4 into main Feb 28, 2024
11 checks passed
@scpeters scpeters deleted the scpeters/spec_1_12 branch February 28, 2024 20:47
aagrawal05 pushed a commit to aagrawal05/sdformat that referenced this pull request Apr 2, 2024
* Set default spec version to 1.12
* Update Migration.md

Signed-off-by: Steve Peters <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants