[quality] Sonar fixes

src/context.cpp

@@ -99,10 +99,20 @@ void Context::receive() {
 	}
 }
 
+/**
+ * \brief Send a message to the server
+ * We assume that the correct IP has been set beforehand
+ * \param code message type
+ * \param message message, formatted as a string
+ */
 void Context::send(const Uint8 code, const std::string & message) {
 	network.send(code, message);
 }
 
+/**
+ * \brief Store the server IP for further use
+ * \param ip address to use
+ */
 void Context::setServerIP(const Uint32 ip) {
 	network.setServerInfo(ip);
 }
@@ -167,7 +177,7 @@ Context * Context::getNextContext(ContextName nextName) {
 			currentContext->leave();
 			if (currentName == ContextName::ROOM) {
 				// Restore the previous lobby
-				Context* previousContext = currentContext;
+				const Context* previousContext = currentContext;
 				currentContext = dynamic_cast<RoomView*>(currentContext)->getLobby();
 				delete previousContext;
 			} else {

src/views/lobbyview.hpp

@@ -26,6 +26,12 @@
 
 class LobbyView : public Context, public gcn::ActionListener {
 public:
+    enum class InteractionMode {
+        WAITING,
+        LOADING, //! room full, coordinates and map are loading
+        EXITING //! loading complete, about to move to RoomView
+    };
+
     explicit LobbyView(ContextName name);
     void action(const gcn::ActionEvent& actionEvent) override;
 

src/views/roomview.cpp

@@ -25,10 +25,9 @@ const Uint16 RoomView::MAX_POWER;
  * Constructor
  * @param view the LobbyView, which already has players and all parameters set
  */
-RoomView::RoomView(LobbyView *view) : Context(ContextName::ROOM),
-gameMode(view->getMode()) {
+RoomView::RoomView(const LobbyView *view) : Context(ContextName::ROOM),
+gameMode(view->getMode()), currentMap(new GameMap(view->getMap())) {
 
-    currentMap = new GameMap(view->getMap());
 
     fg_rect.w = getWidth();
     fg_rect.h = getHeight();
@@ -73,6 +72,7 @@ gameMode(view->getMode()) {
 }
 
 RoomView::~RoomView() {
+    delete currentMap; // because of new in constructor -- improve this
 }
 
 void RoomView::action(const gcn::ActionEvent &actionEvent) {

src/views/roomview.hpp

@@ -55,7 +55,7 @@ class RoomView: public Context, public gcn::ActionListener {
         RESULTS //! match is over
     };
 
-    explicit RoomView(LobbyView *view);
+    explicit RoomView(const LobbyView *view);
     virtual ~RoomView();
 
     void action(const gcn::ActionEvent &actionEvent) override;