Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing tech installation on windows #35

Merged
merged 1 commit into from
May 13, 2024
Merged

fixing tech installation on windows #35

merged 1 commit into from
May 13, 2024

Conversation

tvt173
Copy link
Contributor

@tvt173 tvt173 commented May 13, 2024

On Windows, we cannot create symlinks without admin privileges by default. So, this case is currently handled by copying the klayout folder (instead of creating a symlink), but it uses shutil.copy, which is invalid for copying directories. This PR changes to use copytree instead.

@github-actions github-actions bot added the bug Something isn't working label May 13, 2024
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.

@tvt173 tvt173 requested a review from joamatab May 13, 2024 03:21
@joamatab joamatab merged commit 2cfd3e6 into main May 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants