cspdk cleanup #51
cspdk cleanup #51
Conversation
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
| ret = {} | ||
| for k, v in net.get("instances", {}).items(): | ||
| ret[k] = { | ||
| "component": v.get("component", ""), | ||
| "settings": v.get("settings", {}), | ||
| } | ||
| return ret |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Convert for loop into dictionary comprehension (
dict-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| ret = {} | ||
| for k, v in net.get("instances", {}).items(): | ||
| ret[k] = { | ||
| "component": v.get("component", ""), | ||
| "settings": v.get("settings", {}), | ||
| } | ||
| return ret |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Convert for loop into dictionary comprehension (
dict-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
| ret = {} | ||
| for k, v in net.get("instances", {}).items(): | ||
| ret[k] = { | ||
| "component": v.get("component", ""), | ||
| "settings": v.get("settings", {}), | ||
| } | ||
| return ret |
There was a problem hiding this comment.
issue (code-quality): We've found these issues:
- Convert for loop into dictionary comprehension (
dict-comprehension) - Inline variable that is immediately returned (
inline-immediately-returned-variable)
cspdk/sin300/tech.py
Outdated
| PAD: Layer = (41, 0) | ||
| NITRIDE: Layer = (203, 0) | ||
| NITRIDE_ETCH: Layer = (204, 0) | ||
| # TODO: how can we make this pass type checking? |
There was a problem hiding this comment.
no, that makes pyright error out (not a huge deal, but I like my repositories type clean)
|
it's missing the slab on the i tried debugging it yesterday and coulnd't figure out, if you can run the tests or run
it should look like the version in main
|
|
Hi @joamatab , I think everything is now fixed. I went through the yaml definition differences and decided the differences are fine, so I regenerated the yaml test references. I also went through the gds files and for the most part the differences where fine/to be expected as well. However, there is a minor issue for grating_coupler_rectangular where there seems to be extra padding around the grating in the old version which now seems to be gone in the new version. Can you figure out why? Or if its an issue? below: old, xor, new |
Some more cleanup of cspdk.
passes all tests except regression tests (note: you'll need the current master branch of gdsfactory!)
Please review and let me know what you think @joamatab