Merge pull request #181 from gdsfactory/180-save-name-of-python-funct…

…ion-in-kcell-metadata 180 save name of python function in kcell metadata
gdsfactory · Sep 18, 2023 · 9bf86ce · 9bf86ce
2 parents 957cbe3 + 7cb5026
commit 9bf86ce
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 0 deletions.
diff --git a/changelog.d/180.added.md b/changelog.d/180.added.md
@@ -0,0 +1 @@
+Added  to be set by  decorator
diff --git a/demo.gds b/demo.gds
diff --git a/docs/mkdocs.yml b/docs/mkdocs.yml
@@ -7,6 +7,7 @@ nav:
   - Home:
     - Intro: index.md
     - gdsfactory.md
+    - dosdonts.md
   - First Steps:
     - Prerequisites: pre.md
     - 5min Intro to KFactory: intro.md

diff --git a/docs/source/dosdonts.md b/docs/source/dosdonts.md
@@ -0,0 +1,9 @@
+# Dos and Don'ts
+
+
+## Dos
+
+## Don'ts
+
+* Do not use "function_name" as a function parameter when using `@kf.cell` decorator,
+  it will be overwritten by the function name used to create the cell
diff --git a/src/kfactory/kcell.py b/src/kfactory/kcell.py
@@ -3520,6 +3520,8 @@ def wrapped_cell(
                 if set_settings:
                     settings = cell.settings.model_dump()
                     settings.update(params)
+                    if set_name:
+                        settings["function_name"] = name
                     cell._settings = KCellSettings(**settings)
                 info = cell.info.model_dump()
                 for name, value in cell.info: