Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better PDK cells #171

Merged
merged 23 commits into from
Sep 1, 2023
Merged

Better PDK cells #171

merged 23 commits into from
Sep 1, 2023

Conversation

sebastian-goeldi
Copy link
Collaborator

@sebastian-goeldi sebastian-goeldi commented Aug 9, 2023 •
edited
Loading

  • Allow c << pdk.cell when pdk.kcl (or pdk.kcl.layout is not the same as c.kcl (or layout).
  • KCLayout has always a layout object with a library() is not None
  • Force pdk naming (necessary for library registration in order to derive library name from pdk)
  • Register the Library objects by pdk name
  • Make the library cells not defunct when the library gds is not registered to the GUI (make them static but with proper name prefix)
  • New pdk tests
  • Readd LayerEnclosures and KCellEnclosure

Other fixes:

  • Fix pydantic 1 artifacts (move class Config to class definition)
  • Fix config for proper support of pydantic-settings

@joamatab
@SkandanC

@sebastian-goeldi sebastian-goeldi self-assigned this Aug 9, 2023
@sebastian-goeldi sebastian-goeldi marked this pull request as draft August 9, 2023 21:46
@sebastian-goeldi
Copy link
Collaborator Author

Still needs some updates, but pls review already @SkandanC @joamatab

drinwater
drinwater reviewed Aug 27, 2023
View reviewed changes
src/kfactory/kcell.py Outdated Show resolved Hide resolved
src/kfactory/kcell.py Show resolved Hide resolved
src/kfactory/custom/bezier.py Outdated Show resolved Hide resolved
@sebastian-goeldi sebastian-goeldi marked this pull request as ready for review September 1, 2023 00:59
@sebastian-goeldi sebastian-goeldi added this pull request to the merge queue Sep 1, 2023
Merged via the queue into main with commit 957cbe3 Sep 1, 2023
5 checks passed
@sebastian-goeldi sebastian-goeldi deleted the pdk-cells branch September 1, 2023 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drinwater drinwater drinwater left review comments

@joamatab joamatab Awaiting requested review from joamatab

@SkandanC SkandanC Awaiting requested review from SkandanC

Assignees

@sebastian-goeldi sebastian-goeldi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sebastian-goeldi @drinwater