Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deal with ImageCollection as with Folder #29

Merged
merged 4 commits into from
Jun 30, 2024
Merged

Conversation

12rambau
Copy link
Member

Fix #27

The previous implementation was enable to deal with imageCollection objects. As such if someone wanted to test an ImageCollection asset he was force to run the ImageCollection creation from the code instead of the tree dict description.

In this PR I introduced a new type keyword that need to be specified when crzating containers "IMAGE_COLLECTION" or "FOLDER". like in the documentation example:

{
  "folder::Folder": {
    "image": ee.Image(1).clipToBoundsAndScale(point.buffer(100), scale=30),
    "fc": ee.FeatureCollection(point),
  },
  "image_collection::ImageCollection": {
    "image1": ee.Image(1).clipToBoundsAndScale(point.buffer(100), scale=30),
    "image2": ee.Image(1).clipToBoundsAndScale(point.buffer(100), scale=30),
  }
}

Only "Folder" and ImageCollection" types are supported (and to my knowledge they are currently the only 2 types of containers)

To avoid non-regression an non specified container type will be treated as a Folder.

@12rambau 12rambau merged commit f56b5d9 into main Jun 30, 2024
11 checks passed
@12rambau 12rambau deleted the image_collection branch June 30, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot create ImageCollection assets
1 participant