fix cache.go sync.Mutex, use Lock instead of RLock

geektutu · Feb 11, 2020 · a6535ef · a6535ef
1 parent a441406
commit a6535ef
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 30 deletions.
diff --git a/gee-cache/day2-single-node/geecache/cache.go b/gee-cache/day2-single-node/geecache/cache.go
@@ -6,23 +6,23 @@ import (
 )
 
 type cache struct {
-	mu         sync.RWMutex
+	mu         sync.Mutex
 	lru        *lru.Cache
 	cacheBytes int64
 }
 
 func (c *cache) add(key string, value ByteView) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		c.lru = lru.New(c.cacheBytes, nil)
 	}
 	c.lru.Add(key, value)
 }
 
 func (c *cache) get(key string) (value ByteView, ok bool) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		return
 	}

diff --git a/gee-cache/day3-http-server/geecache/cache.go b/gee-cache/day3-http-server/geecache/cache.go
@@ -6,23 +6,23 @@ import (
 )
 
 type cache struct {
-	mu         sync.RWMutex
+	mu         sync.Mutex
 	lru        *lru.Cache
 	cacheBytes int64
 }
 
 func (c *cache) add(key string, value ByteView) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		c.lru = lru.New(c.cacheBytes, nil)
 	}
 	c.lru.Add(key, value)
 }
 
 func (c *cache) get(key string) (value ByteView, ok bool) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		return
 	}

diff --git a/gee-cache/day4-consistent-hash/geecache/cache.go b/gee-cache/day4-consistent-hash/geecache/cache.go
@@ -6,23 +6,23 @@ import (
 )
 
 type cache struct {
-	mu         sync.RWMutex
+	mu         sync.Mutex
 	lru        *lru.Cache
 	cacheBytes int64
 }
 
 func (c *cache) add(key string, value ByteView) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		c.lru = lru.New(c.cacheBytes, nil)
 	}
 	c.lru.Add(key, value)
 }
 
 func (c *cache) get(key string) (value ByteView, ok bool) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		return
 	}

diff --git a/gee-cache/day5-multi-nodes/geecache/cache.go b/gee-cache/day5-multi-nodes/geecache/cache.go
@@ -6,23 +6,23 @@ import (
 )
 
 type cache struct {
-	mu         sync.RWMutex
+	mu         sync.Mutex
 	lru        *lru.Cache
 	cacheBytes int64
 }
 
 func (c *cache) add(key string, value ByteView) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		c.lru = lru.New(c.cacheBytes, nil)
 	}
 	c.lru.Add(key, value)
 }
 
 func (c *cache) get(key string) (value ByteView, ok bool) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		return
 	}

diff --git a/gee-cache/day6-single-flight/geecache/cache.go b/gee-cache/day6-single-flight/geecache/cache.go
@@ -6,23 +6,23 @@ import (
 )
 
 type cache struct {
-	mu         sync.RWMutex
+	mu         sync.Mutex
 	lru        *lru.Cache
 	cacheBytes int64
 }
 
 func (c *cache) add(key string, value ByteView) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		c.lru = lru.New(c.cacheBytes, nil)
 	}
 	c.lru.Add(key, value)
 }
 
 func (c *cache) get(key string) (value ByteView, ok bool) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		return
 	}

diff --git a/gee-cache/day7-proto-buf/geecache/cache.go b/gee-cache/day7-proto-buf/geecache/cache.go
@@ -6,23 +6,23 @@ import (
 )
 
 type cache struct {
-	mu         sync.RWMutex
+	mu         sync.Mutex
 	lru        *lru.Cache
 	cacheBytes int64
 }
 
 func (c *cache) add(key string, value ByteView) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		c.lru = lru.New(c.cacheBytes, nil)
 	}
 	c.lru.Add(key, value)
 }
 
 func (c *cache) get(key string) (value ByteView, ok bool) {
-	c.mu.RLock()
-	defer c.mu.RUnlock()
+	c.mu.Lock()
+	defer c.mu.Unlock()
 	if c.lru == nil {
 		return
 	}