This repository has been archived by the owner on Sep 21, 2022. It is now read-only.
Fix css coverage issue if using sass variables #644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When a sass is used with the following construct
The parsed css & source map will map the end of rule .selector to the end of the variable declaration instead of the last line.
This is due to buggy source maps in both node-sass & ruby-sass.
A colleague of mine is already fixing lib-sass, which is the c++ sass compiler which is used by node-sass.
Solution
Since css coverage is only interested in a line/block level coverage the start of the last declaration within the rule will be mapped correctly by the source map.
This should also have no effects on just minified css and other pre-compilers like less