Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viz legend #39

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Viz legend #39

merged 3 commits into from
Sep 12, 2024

Conversation

tmushayahama
Copy link
Contributor

Issues

Changed

  • Added the provides input for
  • prettified other icons

cc @pkalita-lbl @kltm @vanaukenk @dustine32

@@ -28,6 +28,7 @@

.header {
@include standard-var-styles(header);
text-align: center;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it seems like a minor thing, but I'd prefer to keep the base style as unopinionated as possible. If a client wants this text centered there is already a way for them to accomplish that, as illustrated here:

wc-gocam-viz::part(legend-header) {
text-align: center;
}

@tmushayahama
Copy link
Contributor Author

@pkalita-lbl thanks, I have removed the styling

@tmushayahama
Copy link
Contributor Author

@pkalita-lbl @kltm should we merge this?

@kltm
Copy link
Member

kltm commented Jul 15, 2024

For #37

Copy link
Collaborator

@pkalita-lbl pkalita-lbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@tmushayahama tmushayahama merged commit c5b8069 into main Sep 12, 2024
1 check passed
@vanaukenk
Copy link

vanaukenk commented Nov 15, 2024

I've checked this on noctua-dev.

The legend now displays the 'provides input for' relation in my test model.

Noting, though, that the width of the relation in the pathway view still looks smaller than the other relations, and in bigger models, the lighter color of that relation can get lost as noted in:
#37 (comment)
#37 (comment)

We can deal with the display issue in separate work, as this PR does fix the legend, as requested.

@tmushayahama @pkalita-lbl @kltm @dustine32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants