-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Viz legend #39
Viz legend #39
Conversation
@@ -28,6 +28,7 @@ | |||
|
|||
.header { | |||
@include standard-var-styles(header); | |||
text-align: center; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it seems like a minor thing, but I'd prefer to keep the base style as unopinionated as possible. If a client wants this text centered there is already a way for them to accomplish that, as illustrated here:
Lines 46 to 48 in 5c373a9
wc-gocam-viz::part(legend-header) { | |
text-align: center; | |
} |
@pkalita-lbl thanks, I have removed the styling |
@pkalita-lbl @kltm should we merge this? |
For #37 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
I've checked this on noctua-dev. The legend now displays the 'provides input for' relation in my test model. Noting, though, that the width of the relation in the pathway view still looks smaller than the other relations, and in bigger models, the lighter color of that relation can get lost as noted in: We can deal with the display issue in separate work, as this PR does fix the legend, as requested. |
Issues
Changed
cc @pkalita-lbl @kltm @vanaukenk @dustine32