feat #372 & #373 #370
Open
feat #372 & #373 #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hich was also fetched with incorrect delay), modify received era histories to make last era's end unbounded
sourabhxyz
changed the title
addRefScript to work with higher plutus versions…tions, extract out stake pools from gygetparameters
…y fetch protocol parameters once per epoch
…onsidering the short epoch size of privnet so as to not encounter past horizon error
4TT1L4
previously approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372, closes #373.
Now era histories are cached through entire run of the program whereas protocol parameters are cached per epoch.
Inside
mkMethodofmakeGetParametersI had added print statements here to track values of the associatedMVarto verify update is correctly occurring, see below logs:This however is removed from final PR as we don't want to perform such IO action inside
MVarupdate.I had also written a privnet test file to verify that new fetch is occurring in next epoch here however this is removed from final PR as it's not automated.
While working on this task, I had noticed a nasty bug where our caching mechanism was essentially broken since when we call methods like
getProtParams'we are actually generating freshMVarinstead of utilising an old one.