Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Genius Yield’s Trading Strategies Competition - Combined rsi bollinger strategy (incl. optional Fear & Greed Index + extras) #57

Conversation

username-anthony-is-not-available
Copy link
Contributor

@username-anthony-is-not-available username-anthony-is-not-available commented Jul 6, 2024

Entry for the Genius Yield’s Trading Strategies Competition

Description: A trading strategy combining RSI, Bollinger Bands, and optionally Fear & Greed Index.
Template name: combined_rsi_bollinger_strategy
Notes:

  1. I had to include dos2unix in the Dockerfile. Otherwise, I was not able to run the shell script in Docker on my Windows 11 laptop. Maybe there is a setting in Git to take care of this. I did not explore other options once I found the solution.
  2. Chrome/ChromeDriver is used to fetch data from external data sources, with two different exemples.
  3. There is more code than just the template because I tried a couple of ideas while playing with the strategy-executor. I left it in this PR, in case others may find this information useful/it could be incorporated in the main branch.

I made a simpler version with just the template in case we were not supposed to touch the Dockerfile: #56. I would prefer to use this PR for the contest, as it includes the optional Fear & Greed Index, but if it is not possible, please use the other PR as my entry.

@username-anthony-is-not-available username-anthony-is-not-available changed the title Combined rsi bollinger strategy and more Genius Yield’s Trading Strategies Competition - Combined rsi bollinger strategy (incl. optional Fear & Greed Index + extras) Jul 6, 2024
@4TT1L4 4TT1L4 self-requested a review July 22, 2024 08:26
@4TT1L4
Copy link
Contributor

4TT1L4 commented Jul 22, 2024

@username-anthony-is-not-available
Thank you for your contributions.

Please reach out to our community manager via Discord, so we could discuss the next steps.

"talipp",
"tgens"
],
"pylint.args": ["--max-line-length=120", "--disable=missing-module-docstring"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to setup pylint for the CI. Thanks for taking the initiative and starting to address this issue.

4TT1L4
4TT1L4 previously approved these changes Aug 4, 2024
Copy link
Contributor

@4TT1L4 4TT1L4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Let's do the polishing in a follow up PR.

@4TT1L4 4TT1L4 merged commit 223bd9b into geniusyield:main Aug 4, 2024
1 check failed
@username-anthony-is-not-available
Copy link
Contributor Author

Verification string: nV1PWP7EIfGq19rBp82e5BeDaju3x5yL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants