Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use effective strain rate in viscoplastic stress limiter case as well #5982

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

anne-glerum
Copy link
Contributor

In the viscoplastic material model, the strain rate can adapted for elastic stresses and is then called effective_edot_ii instead of edot_ii. effective_edot_ii is then used to compute the current cohesion and friction angle and the resulting yield stress. This yield stress is used in the stress limiter case, which however uses edot_ii in further calculations. This PR changes edot_ii to effective_edot_ii in the stress limiter case to be consistent.

For all pull requests:

For new features/models or changes of existing features:

  • I have tested my new feature locally to ensure it is correct.
  • I have created a testcase for the new feature/benchmark in the tests/ directory.
  • I have added a changelog entry in the doc/modules/changes directory that will inform other users of my change.

@tjhei
Copy link
Member

tjhei commented Jul 21, 2024

No test is affected by this. Is this expected?

@anne-glerum
Copy link
Contributor Author

There is only one test that uses the limiter, and it doesn't use elasticity. In this case edot_ii = effective_edot_ii. So yes, it's expected.

@bobmyhill
Copy link
Member

Thanks for the fix @anne-glerum . You commented just before I could press send!

I'll merge this now, as this fix is independent of any testing that we should do (#5983), and I already suggested some potential tests in a reply to a question from @naliboff on Element.

@bobmyhill bobmyhill merged commit ebebac8 into geodynamics:main Jul 22, 2024
8 checks passed
@anne-glerum anne-glerum deleted the use_effective_edot_ii branch July 22, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants