Set default georchestra datadir location #147
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to set the default geOrchestra datadir location. In order to avoid having to specify it in all our deployments.
/etc/georchestra
is a standard directory used in Docker and even in Debian package for geOrchestra.It is already included inside many of our Dockerfile: https://github.com/search?q=repo%3Ageorchestra%2Fgeorchestra%20%2Fetc%2Fgeorchestra&type=code and even sometimes in the application.yml itself: https://github.com/georchestra/georchestra/blob/5f9743f0a773eaf5f276ca459c80423e16cad364/datafeeder/src/main/resources/application.yml#L108
I'm proposing this PR because as of right now we can't customize the Dockerfile so we can't set a default geOrchestra datadir location through this file.
@pmauduit told me that you can still change the parameter even though it is compiled from the source code: https://docs.spring.io/spring-boot/reference/features/external-config.html. Using a method like
JAVA_TOOL_OPTIONS: "-Dgeorchestra.datadir=/etc/georchestra"
. So nobody is stuck with this static directory.