Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The output column of forecast functions are not correctly set #1102

Closed
2 tasks done
xzdandy opened this issue Sep 12, 2023 · 0 comments · Fixed by #1108
Closed
2 tasks done

The output column of forecast functions are not correctly set #1102

xzdandy opened this issue Sep 12, 2023 · 0 comments · Fixed by #1108
Assignees
@xzdandy
Labels
Bug 🐞 EVA is not working as expected
Milestone
v0.3.5

Comments

@xzdandy
Copy link
Collaborator

xzdandy commented Sep 12, 2023 •
edited
Loading

Search before asking

  • I have searched the EvaDB issues and found no similar bug report.

Bug

In evadb/functions/forecast.py, the output dataframe has three columns: unique_id, datestamp, and forecasting value. However, in binder (

evadb/evadb/binder/statement_binder.py

Line 99 in 788d65e

outputs.append(column)
), we only set the forecasting value column.

This results the output of SELECT Forecast(12); only contains the forecasting value column and loses the other two columns.

Environment

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@xzdandy xzdandy added the Bug 🐞 EVA is not working as expected label Sep 12, 2023
@xzdandy xzdandy added this to the v0.3.5 milestone Sep 12, 2023
@xzdandy xzdandy self-assigned this Sep 13, 2023
@xzdandy xzdandy linked a pull request Sep 13, 2023 that will close this issue
Set the right output column type for forecast functions #1108
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xzdandy xzdandy

Labels
Bug 🐞 EVA is not working as expected
Projects
None yet
Milestone
v0.3.5
Development

Successfully merging a pull request may close this issue.

Set the right output column type for forecast functions georgia-tech-db/evadb
1 participant
@xzdandy