Set the right output column type for forecast functions #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
@hershd23 I have moved the |
americast
reviewed
Sep 13, 2023
| if frequency is None: | ||
| raise RuntimeError( | ||
| f"Can not infer the frequency for {self.node.name}. Please explictly set it." | ||
| ) |
There was a problem hiding this comment.
This is great, thanks for adding this!
hershd23
approved these changes
Sep 13, 2023
| from evadb.utils.generic_utils import string_comparison_case_insensitive | ||
|
|
||
|
|
||
| class GenericUtilsTests(unittest.TestCase): |
There was a problem hiding this comment.
Ah I was wondering whether to create a new test file add in a new file or not. Thanks for this, makes it clear
xzdandy
deleted the
1102-the-output-column-of-forecast-functions-are-not-correctly-set
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current forecast functions only output the y value. This PR fixes the binded output column, so forecasting functions also return unqiue_id and datastamp column.