Load query exception for invalid file format #1159
Conversation
|
Thanks for looking into this! To make sure my understanding is correct, this improves the error message but does not enable the case insensitive type comparison. |
| @@ -30,6 +31,9 @@ def exec(self, *args, **kwargs): | |||
| """ | |||
|
|
|||
| # invoke the appropriate executor | |||
| if self.node.file_options["file_format"] is None: | |||
There was a problem hiding this comment.
Please loop over all the possible enum values so that we don’t need to update this if we add more types later. Thanks!
There was a problem hiding this comment.
@gaurav274 , in this if condition we are checking if we are receiving the file format none. It would be the case only if the file format is not their in lark parser.
And after this there is a condition already available where we are checking all the available file format and passing it to the load executor
Yes. I feel just providing better error message is good enough. Shall we also make it case insensitive? |
Yes i will add a testcase |
Yes it just gives the correct error message |
No description provided.