Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Sklearn linear regression in EvaDB #1162

Merged
merged 4 commits into from
Sep 22, 2023

Conversation

jineetd
Copy link
Contributor

@jineetd jineetd commented Sep 19, 2023

Starting this PR for integrating sklearn linear regression for EvaDb.

@jineetd
Copy link
Contributor Author

jineetd commented Sep 19, 2023

Currently the integration test is failing with the following error:

TypeError: Singleton array array('rental_price', dtype='<U12') cannot be considered a valid collection.
============================================================================================= short test summary info ==============================================================================================
FAILED test/integration_tests/long/test_model_train.py::ModelTrainTests::test_sklearn_regression - evadb.executor.executor_utils.ExecutorError: Singleton array array('rental_price', dtype='<U12') cannot be considered a valid collection.

Seems like something is wrong with return types somewhere. Need to debug further.

@xzdandy xzdandy added Work In Progress 🚧 Integrations 🧩 Pull requests that update an integration labels Sep 19, 2023
@xzdandy xzdandy linked an issue Sep 19, 2023 that may be closed by this pull request
5 tasks
@xzdandy xzdandy added this to the v0.3.6 milestone Sep 20, 2023
evadb/functions/sklearn.py Outdated Show resolved Hide resolved
@jineetd
Copy link
Contributor Author

jineetd commented Sep 21, 2023

Unit test is passing with these changes.

@xzdandy xzdandy added AI Engines Features, Bugs, related to AI Engines and removed Work In Progress 🚧 labels Sep 22, 2023
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks great. Add some comments. We are good to merge then. Thanks for the contribution!

@xzdandy xzdandy mentioned this pull request Sep 22, 2023
5 tasks
@xzdandy xzdandy merged commit 0de4cd2 into georgia-tech-db:staging Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Engines Features, Bugs, related to AI Engines Integrations 🧩 Pull requests that update an integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sklearn Integration
2 participants