-
Notifications
You must be signed in to change notification settings - Fork 265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Llm operator #1313
Draft
gaurav274
wants to merge
8
commits into
staging
Choose a base branch
from
llm_operator
base: staging
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat: Llm operator #1313
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
26607be
[RELEASE]: 0.3.8
jiashenC 59f85fa
[BUMP]: v0.3.9+dev
jiashenC 42a3850
chekcpoint
gaurav274 76174e1
merge upstream
gaurav274 960d33b
fix linter
gaurav274 affa8ec
revert changes
gaurav274 55d1727
revert
gaurav274 8414c3e
llm cost added
gaurav274 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,223 @@ | ||
# coding=utf-8 | ||
# Copyright 2018-2023 EvaDB | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
from pathlib import Path | ||
|
||
from evadb.binder.binder_utils import ( | ||
BinderError, | ||
extend_star, | ||
resolve_alias_table_value_expression, | ||
) | ||
from evadb.binder.statement_binder import StatementBinder | ||
from evadb.catalog.catalog_utils import ( | ||
get_metadata_properties, | ||
get_video_table_column_definitions, | ||
) | ||
from evadb.configuration.constants import EvaDB_INSTALLATION_DIR | ||
from evadb.executor.execution_context import Context | ||
from evadb.expression.function_expression import FunctionExpression | ||
from evadb.expression.tuple_value_expression import TupleValueExpression | ||
from evadb.parser.types import FunctionType | ||
from evadb.third_party.huggingface.binder import assign_hf_function | ||
from evadb.utils.generic_utils import ( | ||
load_function_class_from_file, | ||
string_comparison_case_insensitive, | ||
) | ||
from evadb.utils.logging_manager import logger | ||
|
||
|
||
def bind_func_expr(binder: StatementBinder, node: FunctionExpression): | ||
# setup the context | ||
# we read the GPUs from the catalog and populate in the context | ||
gpus_ids = binder._catalog().get_configuration_catalog_value("gpu_ids") | ||
node._context = Context(gpus_ids) | ||
|
||
# handle the special case of "extract_object" | ||
if node.name.upper() == str(FunctionType.EXTRACT_OBJECT): | ||
handle_bind_extract_object_function(node, binder) | ||
return | ||
|
||
# handle the special case of "completion or chatgpt" | ||
if string_comparison_case_insensitive( | ||
node.name, "chatgpt" | ||
) or string_comparison_case_insensitive(node.name, "completion"): | ||
handle_bind_llm_function(node, binder) | ||
|
||
# Handle Func(*) | ||
if ( | ||
len(node.children) == 1 | ||
and isinstance(node.children[0], TupleValueExpression) | ||
and node.children[0].name == "*" | ||
): | ||
node.children = extend_star(binder._binder_context) | ||
# bind all the children | ||
for child in node.children: | ||
binder.bind(child) | ||
|
||
function_obj = binder._catalog().get_function_catalog_entry_by_name(node.name) | ||
if function_obj is None: | ||
err_msg = ( | ||
f"Function '{node.name}' does not exist in the catalog. " | ||
"Please create the function using CREATE FUNCTION command." | ||
) | ||
logger.error(err_msg) | ||
raise BinderError(err_msg) | ||
|
||
if string_comparison_case_insensitive(function_obj.type, "HuggingFace"): | ||
node.function = assign_hf_function(function_obj) | ||
|
||
elif string_comparison_case_insensitive(function_obj.type, "Ludwig"): | ||
function_class = load_function_class_from_file( | ||
function_obj.impl_file_path, | ||
"GenericLudwigModel", | ||
) | ||
function_metadata = get_metadata_properties(function_obj) | ||
assert "model_path" in function_metadata, "Ludwig models expect 'model_path'." | ||
node.function = lambda: function_class( | ||
model_path=function_metadata["model_path"] | ||
) | ||
|
||
else: | ||
if function_obj.type == "ultralytics": | ||
# manually set the impl_path for yolo functions we only handle object | ||
# detection for now, hopefully this can be generalized | ||
function_dir = Path(EvaDB_INSTALLATION_DIR) / "functions" | ||
function_obj.impl_file_path = ( | ||
Path(f"{function_dir}/yolo_object_detector.py").absolute().as_posix() | ||
) | ||
|
||
# Verify the consistency of the function. If the checksum of the function does not | ||
# match the one stored in the catalog, an error will be thrown and the user | ||
# will be asked to register the function again. | ||
# assert ( | ||
# get_file_checksum(function_obj.impl_file_path) == function_obj.checksum | ||
# ), f"""Function file {function_obj.impl_file_path} has been modified from the | ||
# registration. Please use DROP FUNCTION to drop it and re-create it # using CREATE FUNCTION.""" | ||
|
||
try: | ||
function_class = load_function_class_from_file( | ||
function_obj.impl_file_path, | ||
function_obj.name, | ||
) | ||
# certain functions take additional inputs like yolo needs the model_name | ||
# these arguments are passed by the user as part of metadata | ||
|
||
properties = get_metadata_properties(function_obj) | ||
node.function = lambda: function_class(**properties) | ||
except Exception as e: | ||
err_msg = ( | ||
f"{str(e)}. Please verify that the function class name in the " | ||
"implementation file matches the function name." | ||
) | ||
logger.error(err_msg) | ||
raise BinderError(err_msg) | ||
|
||
node.function_obj = function_obj | ||
output_objs = binder._catalog().get_function_io_catalog_output_entries(function_obj) | ||
if node.output: | ||
for obj in output_objs: | ||
if obj.name.lower() == node.output: | ||
node.output_objs = [obj] | ||
if not node.output_objs: | ||
err_msg = f"Output {node.output} does not exist for {function_obj.name}." | ||
logger.error(err_msg) | ||
raise BinderError(err_msg) | ||
node.projection_columns = [node.output] | ||
else: | ||
node.output_objs = output_objs | ||
node.projection_columns = [obj.name.lower() for obj in output_objs] | ||
|
||
resolve_alias_table_value_expression(node) | ||
|
||
|
||
def handle_bind_llm_function(node, binder): | ||
# we also handle the special case of ChatGPT where we need to send the | ||
# OpenAPI key as part of the parameter if not provided by the user | ||
function_obj = binder._catalog().get_function_catalog_entry_by_name(node.name) | ||
properties = get_metadata_properties(function_obj) | ||
# if the user didn't provide any API_KEY, check if we have one in the catalog | ||
if "OPENAI_API_KEY" not in properties.keys(): | ||
openapi_key = binder._catalog().get_configuration_catalog_value( | ||
"OPENAI_API_KEY" | ||
) | ||
properties["openai_api_key"] = openapi_key | ||
|
||
|
||
def handle_bind_extract_object_function( | ||
node: FunctionExpression, binder_context: StatementBinder | ||
): | ||
"""Handles the binding of extract_object function. | ||
1. Bind the source video data | ||
2. Create and bind the detector function expression using the provided name. | ||
3. Create and bind the tracker function expression. | ||
Its inputs are id, data, output of detector. | ||
4. Bind the EXTRACT_OBJECT function expression and append the new children. | ||
5. Handle the alias and populate the outputs of the EXTRACT_OBJECT function | ||
|
||
Args: | ||
node (FunctionExpression): The function expression representing the extract object operation. | ||
binder_context (StatementBinder): The binder object used to bind expressions in the statement. | ||
|
||
Raises: | ||
AssertionError: If the number of children in the `node` is not equal to 3. | ||
""" | ||
assert ( | ||
len(node.children) == 3 | ||
), f"Invalid arguments provided to {node}. Example correct usage, (data, Detector, Tracker)" | ||
|
||
# 1. Bind the source video | ||
video_data = node.children[0] | ||
binder_context.bind(video_data) | ||
|
||
# 2. Construct the detector | ||
# convert detector to FunctionExpression before binding | ||
# eg. YoloV5 -> YoloV5(data) | ||
detector = FunctionExpression(None, node.children[1].name) | ||
detector.append_child(video_data.copy()) | ||
binder_context.bind(detector) | ||
|
||
# 3. Construct the tracker | ||
# convert tracker to FunctionExpression before binding | ||
# eg. ByteTracker -> ByteTracker(id, data, labels, bboxes, scores) | ||
tracker = FunctionExpression(None, node.children[2].name) | ||
# create the video id expression | ||
columns = get_video_table_column_definitions() | ||
tracker.append_child( | ||
TupleValueExpression(name=columns[1].name, table_alias=video_data.table_alias) | ||
) | ||
tracker.append_child(video_data.copy()) | ||
binder_context.bind(tracker) | ||
# append the bound output of detector | ||
for obj in detector.output_objs: | ||
col_alias = "{}.{}".format(obj.function_name.lower(), obj.name.lower()) | ||
child = TupleValueExpression( | ||
obj.name, | ||
table_alias=obj.function_name.lower(), | ||
col_object=obj, | ||
col_alias=col_alias, | ||
) | ||
tracker.append_child(child) | ||
|
||
# 4. Bind the EXTRACT_OBJECT expression and append the new children. | ||
node.children = [] | ||
node.children = [video_data, detector, tracker] | ||
|
||
# 5. assign the outputs of tracker to the output of extract_object | ||
node.output_objs = tracker.output_objs | ||
node.projection_columns = [obj.name.lower() for obj in node.output_objs] | ||
|
||
# 5. resolve alias based on the what user provided | ||
# we assign the alias to tracker as it governs the output of the extract object | ||
resolve_alias_table_value_expression(node) | ||
tracker.alias = node.alias |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not adding the LLM operator to the parser? So, the allowed LLM names are restricted here?