Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifying users about incorrect forward headers #1392

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

hershd23
Copy link
Contributor

@hershd23 hershd23 commented Nov 25, 2023

To the existing error message adding

  1. What signature failed (input or output)
  2. Providing a signature template to the user
  3. Added link to the forward decorator in the EvaDB documentation

Pointing users to the following documentation
https://evadb.readthedocs.io/en/stable/source/reference/ai/custom-ai-function.html#part-1-writing-a-custom-function

@hershd23 hershd23 requested review from jarulraj and xzdandy November 25, 2023 00:15
@hershd23 hershd23 linked an issue Nov 25, 2023 that may be closed by this pull request
2 tasks
@xzdandy xzdandy added this to the V0.3.10 milestone Nov 28, 2023
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving the error message!

@xzdandy xzdandy merged commit bbfa483 into georgia-tech-db:staging Nov 28, 2023
7 checks passed
@xzdandy xzdandy linked an issue Nov 28, 2023 that may be closed by this pull request
2 tasks
@xzdandy xzdandy removed this from the V0.3.10 milestone Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notify Users about Invalid Forward Headers
2 participants