Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows CI test and setup regression tests against known output #27

Open
wants to merge 29 commits into
base: main
Choose a base branch
from

Conversation

K20shores
Copy link
Contributor

@K20shores K20shores commented Sep 20, 2024

Name and Institution (Required)

Name: Kyle Shores
Institution: NCAR

Describe the update

  • Adds a github actions test that builds on windows.
  • Adds a test which runs CloudJ against known output

Expected changes

None.

Reference(s)

Related Github Issues and PRs

@lizziel
Copy link
Contributor

lizziel commented Sep 30, 2024

Thanks @K20shores. I can bring this in into the next version. I kept around the netcdf support just in case we want to read data as netcdf in the future. For example, there's a climatology file read for standalone that is currently ascii but it could easily be netcdf instead. This is not essential, however, and we can bring back netcdf support at the time we want to add it.

@K20shores
Copy link
Contributor Author

@lizziel we figured out how to build TUVx on windows while including netcdf (NCAR/tuv-x#112). Would you like me to rollback the changes that remove netcdf?

@lizziel
Copy link
Contributor

lizziel commented Nov 12, 2024

@K20shores, yes, if there is no need to delete then let's keep it in there.

@K20shores
Copy link
Contributor Author

@lizziel done. The changes look much smaller now that netcdf has been put back

- Tests which compare the output of Cloud-J to some saved reference output.

### Changed
- The try_compile.f90 file no longer tries to use netcdf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change still true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants