Bug fixes for the carbon simulations in GCClassic and GCHP #2554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mbustion emissions The emission for GHGI_EE_COAST_OTHER_MCOMB in HEMCO_Config.rc.CH4 was incorrectly assigned a hierarcy of 100 (added to regional US emissions) when it should have been 1 (added to EDGAR global emissions). The wrong mask was also applied to this field - it should be 1009 (CONUS_MASK_MIRROR) and not 1008 (CONUS_MASK). These typos caused mobile combustion emissions to be double counted over the US. The typos were not present in the HEMCO_Config.rc files for carbon simulations. Also made other white space and comment updates to HEMCO_Config.rc files for the carbon and CH4 simulations to ensure consistency between the two simulations. Signed-off-by: Melissa Sulprizio <[email protected]>
…n against carbon simulation The carbon simulation currently uses GFED biomass burning emissions by default (for all carbon species). It also uses GEOS-Chem v5 OH which is currently required for CH4 in the carbon simulation. To simplify validation of the CO in the tagCO simulation vs the carbon simulation, we update the HEMCO_Config.rc.tagCO to use the same options. Also made a minor change to the OCS biomass burning diagnostic name for consistency with the other carbon species. Signed-off-by: Melissa Sulprizio <[email protected]>
This update prevents printing a message every timestep intended only to be printed once. Signed-off-by: Lizzie Lundgren <[email protected]>
The activate flag is needed in the transport menu since it is used to set Input_Opt%LTRAN. This update fixes a bug that caused mixing ratio update with pressure ratio every timestep. Signed-off-by: Lizzie Lundgren <[email protected]>
…lassic The scale factor is removed from HEMCO_Config.rc since the conversion happens automatically in HEMCO read for GC-Classic. For GCHP the scale factor is now configured in ExtData.rc. Signed-off-by: Lizzie Lundgren <[email protected]>
Signed-off-by: Lizzie Lundgren <[email protected]>
All emissions for OCS are surface so total can be 2-dimensional rather than 3-dimensional. Signed-off-by: Lizzie Lundgren <[email protected]>
msulprizio
changed the title
msulprizio
added
category: Bug Fix
|
@msulprizio I can successfully compile GCHP 14.5.0, but when I include these bug fixes, the following error appears. [ 93%] Building Fortran object src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/emissions_mod.F90.o
/nobackup/lwu5/GCHP/src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/emissions_mod.F90(127): error #6580: Name in only-list does not exist or is not accessible. [EMISS_CARBON_GASES]
USE Carbon_Gases_Mod, ONLY : Emiss_Carbon_Gases
--------------------------------------^
compilation aborted for /nobackup/lwu5/GCHP/src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/emissions_mod.F90 (code 1)
make[2]: *** [src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/build.make:283: src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/emissions_mod.F90.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:11451: src/GCHP_GridComp/GEOSChem_GridComp/geos-chem/GeosCore/CMakeFiles/GeosCore.dir/all] Error 2
make: *** [Makefile:166: all] Error 2I found the updated emissions_mod.F90 somewhere, but it doesn't included in the "Files Changed" here. Now the GCClassic is successfully compiled. I'll also try GCHP later. |
Signed-off-by: Lizzie Lundgren <[email protected]>
yantosca
added
the
no-diff-to-benchmark
|
@yidant Would you please upload $ROOT/CH4/v2024-01/ResME/reservoir_mask.01x01.nc to the data server? Thank you. |
|
Thanks @Aosrain! This file is synced! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name and Institution (Required)
Name: Melissa Sulprizio & Lizzie Lundgren
Institution: Harvard University
Describe the update
This pull request contains several fixes and updates to the carbon simulation to (1) reproduce carbon species in the GCClassic standalone CH4, CO2, and tagCO simulations and (2) ensure consistent results between the carbon simulation in GCClassic and GCHP.
Expected changes
These changes impact only the carbon, CH4, CO2, and tagCO simulations and do not impact the full-chemistry benchmark simulations.
Related Github Issue