Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated path in notebook to 2023 aqcuired data #137

Merged
merged 3 commits into from
Sep 23, 2023

Conversation

JKutt
Copy link
Collaborator

@JKutt JKutt commented Sep 22, 2023

A quick PR to update the path to magnetic data file acquired 2023 for EOAS 350

@JKutt JKutt self-assigned this Sep 22, 2023
@JKutt
Copy link
Collaborator Author

JKutt commented Sep 22, 2023

@santisoler , it looks like some of the notebook parameters changed to older versions after saving the edit to the file path. Will this matter. Should I maybe just edit the straight text?

@santisoler
Copy link
Member

Thanks for this PR @JKutt! I suspect those values will be overwritten when the students open the notebook with the kernels in the JupyterHub. But if we want to be sure we are not going to break anything, we can totally restore the previous changes on those two lines. I can do it, no worries.

On a side note, I would merge this PR after the file is uploaded.

Copy link
Member

@santisoler santisoler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions to restore the original kernel parameters in the notebook

notebooks/mag/Mag_FitProfile.ipynb Outdated Show resolved Hide resolved
notebooks/mag/Mag_FitProfile.ipynb Outdated Show resolved Hide resolved
@santisoler santisoler merged commit 0911a04 into geoscixyz:main Sep 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants